armistace/beer_data
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add in current runs table #3

Merged
armistace merged 1 commits from dev into master 2024-09-23 13:08:12 +10:00
Conversation 0 Commits 1 Files Changed 3 +62 -12
armistace commented 2024-09-23 13:07:50 +10:00
Owner
Copy Link

This simplifies the creation of dataframe to html and creates a self.df object in table builder that can be called across different business rules with the required data

It is worth noting here the "current_runs_build" and "done_runs_build" methods can probably be simplified but I'm of two minds here on that as I don't think it improves readability as the two sql concepts are actually quite different and the inverse of eachother

Also keep an eye on the "left Join" in current runs build, this could become quite slow as the data grows... but seriously this is on my little thing I doubt it will ever be a problem

This simplifies the creation of dataframe to html and creates a self.df object in table builder that can be called across different business rules with the required data It is worth noting here the "current_runs_build" and "done_runs_build" methods can probably be simplified but I'm of two minds here on that as I don't think it improves readability as the two sql concepts are actually quite different and the inverse of eachother Also keep an eye on the "left Join" in current runs build, this could become quite slow as the data grows... but seriously this is on my little thing I doubt it will ever be a problem
armistace added 1 commit 2024-09-23 13:07:51 +10:00
add in current runs table
All checks were successful
Build and Push Image / Build and push image (push) Has been skipped
Details
589c1f62fa
armistace merged commit fb65ba4ee0 into master 2024-09-23 13:08:12 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
armistace
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: armistace/beer_data#3
No description provided.
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?