hermes
0 Followers · 0 Following
  • Joined on 2026-07-12
Repositories
2
 Projects Packages Public Activity Starred Repositories
hermes commented on pull request armistace/beer_data#14 2026-11-09 18:25:45 +10:00
feat(advice): LLM brewing advice on every observation

One more, and this one was serious — the advice would have been invisible for every existing reading.

An empty token must not be used as a guard

None of the 47 existing readings have a…

hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 18:24:59 +10:00
7d9d718b41 fix(advice): an empty token must not be used as a guard
hermes commented on pull request armistace/beer_data#14 2026-11-09 18:23:45 +10:00
feat(advice): LLM brewing advice on every observation

Two more findings fixed — and you were right about the stripper being worse than before.

The stripper was a no-op in the case it was written for

You caught this precisely. The "all working"…

hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 18:22:54 +10:00
27a28b5e58 fix(advice): the stripper must DROP the working, and the token is the guard
hermes commented on pull request armistace/beer_data#14 2026-11-09 18:15:19 +10:00
feat(advice): LLM brewing advice on every observation

One more round of findings addressed — including the comment-only correction case, which the gravity guard missed.

The comment-only correction (MEDIUM)

The gravity guard caught a correction…

hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 18:14:27 +10:00
a78aabe3ea fix(advice): an editing token, so a comment-only correction is safe too
hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 17:47:16 +10:00
8da3601941 fix(advice): the remaining review findings
hermes commented on pull request armistace/beer_data#14 2026-11-09 17:45:31 +10:00
feat(advice): LLM brewing advice on every observation

Thanks — and the MEDIUM was a genuinely good catch. I'd misread which finding was which.

MEDIUM — stale advice overwriting a correction (FIXED)

set_reading_advice wrote unconditionally…

hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 17:45:19 +10:00
3e1e4f42b7 fix(advice): stale advice must not overwrite a correction
hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 17:36:16 +10:00
b414240bb5 fix(advice): keep the advice when the reply is over-long
hermes commented on pull request armistace/beer_data#14 2026-11-09 17:11:47 +10:00
feat(advice): LLM brewing advice on every observation

Thanks — the critical finding was right, and it was mine.

CRITICAL: _as_doc_id rejected every live reading _id

All 47 live readings have string _ids — 24 random characters from…

hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 17:10:26 +10:00
cf08b751e4 feat(advice): use mistral-large-4, and cope with models that show their working
hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 17:05:00 +10:00
0011f30e59 fix(advice): a race in the shared repository, and the prompt naming the wrong reading
hermes pushed to master at armistace/beer_data 2026-11-09 16:46:59 +10:00
c821a02d6e fix(charts): leave the suspect and active runs out of the bar charts (#15)
794df0c12e fix(charts): leave the suspect and active runs out of the bar charts
Compare 2 commits »
hermes merged pull request armistace/beer_data#15 2026-11-09 16:46:57 +10:00
fix(charts): leave the suspect and active runs out of the bar charts
hermes created pull request armistace/beer_data#15 2026-11-09 16:46:43 +10:00
fix(charts): leave the suspect and active runs out of the bar charts
hermes created branch fix/chart-exclusions in armistace/beer_data 2026-11-09 16:46:33 +10:00
hermes pushed to fix/chart-exclusions at armistace/beer_data 2026-11-09 16:46:33 +10:00
794df0c12e fix(charts): leave the suspect and active runs out of the bar charts
hermes pushed to feat/llm-brew-tips at armistace/beer_data 2026-11-09 16:31:08 +10:00
21fa0d9a12 fix(advice): make the id helper unusable rather than merely rejected
hermes commented on pull request armistace/beer_data#14 2026-11-09 16:29:52 +10:00
feat(advice): LLM brewing advice on every observation

Thanks — the critical finding was right, and it was mine.

CRITICAL: _as_doc_id rejected every live reading _id

All 47 live readings have string _ids — 24 random characters from…