fix(charts): leave the suspect and active runs out of the bar charts
The second review of PR #12 (after the suspect-run fix) found that the two BAR charts were still plotting runs they should not have been, while the curve chart and the tiles had been corrected. The page was contradicting itself. The ABV chart plotted the suspect run -------------------------------------- Run 12's impossible reading gives it an ABV of 18.64%. The chart's y axis went to 18.64, so the fifteen real bars were squashed into the bottom ~45% of the plot - while the "Strongest 8.53%" tile on the same page showed the correct figure. The chart now leaves the suspect runs out. The attenuation chart plotted the active runs ---------------------------------------------- An active run's attenuation is measured against its CURRENT gravity, so a brew that has just started shows a 0% bar. That is the absence of a result, not a result, and it sat directly above the table of finished brews. The chart now leaves the active runs out. Verified against the live data: ABV chart bars: bars=15 max=8.53 (was 16 bars, max 18.64) attenuation chart bars: bars=15 min=76.2 (was 17 bars, min 0) A suspect active run no longer vanishes --------------------------------------- The API flags suspect runs over EVERY run, so the charts leave them out. But the analysis page only looked at the finished ones, so an active run with a bad reading would be dropped from the charts and never listed in "Readings that need a second look" - it would disappear with no explanation anywhere. The analysis page now lists suspect active runs too. The figures say what they are based on -------------------------------------- - The analysis prose counted the non-suspect runs, not the ones that actually contributed a figure to the mean. It now counts the latter. - The history page's "Average ABV — across finished brews" was averaging 15 of 16 without saying so, while the analysis page said "16 brews (15 counted)". It now says "across 15 of 16 finished brews". - `/api/runs/<run_id>` carries the `suspect` and `active` flags that `/api/runs` does. 148 tests (up from 142).
This commit is contained in:
@@ -508,3 +508,121 @@ def test_the_charts_fetch_the_run_payload_once():
|
||||
"the run payload should be fetched once and shared"
|
||||
)
|
||||
assert "function fetchRuns()" in charts_js
|
||||
|
||||
# ------------------------------------------------- the chart exclusions #
|
||||
|
||||
def test_the_abv_chart_leaves_out_the_suspect_runs():
|
||||
"""A suspect run's ABV comes from an impossible reading.
|
||||
|
||||
Run 12 reads 18.64%, and plotting it stretched the y axis so every
|
||||
real bar was squashed into the bottom of the plot - while the
|
||||
"Strongest" tile on the same page correctly showed 8.53%. The chart
|
||||
and the tile contradicted each other.
|
||||
"""
|
||||
charts_js = (
|
||||
Path(__file__).resolve().parents[1]
|
||||
/ "src" / "flask" / "static" / "js" / "charts.js"
|
||||
).read_text()
|
||||
|
||||
abv_chart = charts_js.split("function drawAbvChart")[1]
|
||||
abv_chart = abv_chart.split("function drawMonthsChart")[0]
|
||||
assert "!r.suspect" in abv_chart, (
|
||||
"the ABV chart must leave the suspect runs out"
|
||||
)
|
||||
|
||||
|
||||
def test_the_attenuation_chart_leaves_out_the_active_runs():
|
||||
"""An active run's attenuation is measured against its CURRENT gravity.
|
||||
|
||||
A brew that has just started shows a 0% bar - which is the absence of
|
||||
a result, not a result. The chart sits above the table of finished
|
||||
brews.
|
||||
"""
|
||||
charts_js = (
|
||||
Path(__file__).resolve().parents[1]
|
||||
/ "src" / "flask" / "static" / "js" / "charts.js"
|
||||
).read_text()
|
||||
|
||||
att_chart = charts_js.split("function drawAttenuationChart")[1]
|
||||
att_chart = att_chart.split("function drawCurveChart")[0]
|
||||
assert "!r.active" in att_chart, (
|
||||
"the attenuation chart must leave the active runs out"
|
||||
)
|
||||
|
||||
|
||||
def test_a_suspect_active_run_is_still_listed_for_review(logged_in, repo):
|
||||
"""A bad reading in an active run must not make the run vanish.
|
||||
|
||||
The API flags suspect runs over EVERY run, so the charts leave them
|
||||
out. If the analysis page only looked at the finished ones, an
|
||||
active run with a bad reading would disappear with no explanation
|
||||
anywhere.
|
||||
"""
|
||||
seed_readings(repo, [
|
||||
("1", "Finished ale", "1050", "2026-01-01", False, ""),
|
||||
("1", "Finished ale", "1010", "2026-01-10", True, ""),
|
||||
# An ACTIVE run whose latest reading is below water.
|
||||
("20", "Active brew", "1042", "2026-02-01", False, ""),
|
||||
("20", "Active brew", "0900", "2026-02-10", False, "typo"),
|
||||
])
|
||||
|
||||
response = logged_in.get("/analysis")
|
||||
body = response.get_data(as_text=True)
|
||||
|
||||
assert "Readings that need a second look" in body
|
||||
assert "0.900" in body
|
||||
|
||||
|
||||
def test_the_history_page_says_how_many_brews_the_abv_figure_is_from(logged_in, repo):
|
||||
"""The tile must not quietly average fewer brews than it claims."""
|
||||
seed_readings(repo, [
|
||||
("1", "Good ale", "1050", "2026-01-01", False, ""),
|
||||
("1", "Good ale", "1010", "2026-01-10", True, ""),
|
||||
("12", "Bad brew", "1042", "2026-01-01", False, ""),
|
||||
("12", "Bad brew", "0900", "2026-02-26", True, "typo"),
|
||||
])
|
||||
|
||||
response = logged_in.get("/history")
|
||||
body = response.get_data(as_text=True)
|
||||
|
||||
assert "across 1 of 2 finished brews" in body
|
||||
|
||||
|
||||
def test_the_analysis_prose_counts_the_brews_that_contributed(logged_in, repo):
|
||||
"""The prose must not claim more brews than actually contributed.
|
||||
|
||||
The prose is rendered from the attenuation figures, so it counts the
|
||||
brews that produced one - not the brews that were merely counted.
|
||||
"""
|
||||
seed_readings(repo, [
|
||||
("1", "Good ale", "1050", "2026-01-01", False, ""),
|
||||
("1", "Good ale", "1010", "2026-01-10", True, ""),
|
||||
("2", "Good pale", "1042", "2026-02-01", False, ""),
|
||||
("2", "Good pale", "1012", "2026-02-10", True, ""),
|
||||
("12", "Bad brew", "1042", "2026-01-01", False, ""),
|
||||
("12", "Bad brew", "0900", "2026-02-26", True, "typo"),
|
||||
])
|
||||
|
||||
response = logged_in.get("/analysis")
|
||||
body = " ".join(response.get_data(as_text=True).split())
|
||||
|
||||
# Three finished brews, two of which contributed an attenuation.
|
||||
assert "Across 2 of 3 finished brews" in body
|
||||
|
||||
|
||||
def test_the_run_detail_api_carries_the_same_flags(logged_in, repo):
|
||||
"""A consumer of the detail endpoint can tell an impossible run from a
|
||||
good one, and an active run from a finished one."""
|
||||
seed_readings(repo, [
|
||||
("1", "Good ale", "1050", "2026-01-01", False, ""),
|
||||
("1", "Good ale", "1010", "2026-01-10", True, ""),
|
||||
("20", "Active brew", "1042", "2026-02-01", False, ""),
|
||||
])
|
||||
|
||||
finished = logged_in.get("/api/runs/1").get_json()
|
||||
assert finished["suspect"] is False
|
||||
assert finished["active"] is False
|
||||
|
||||
active = logged_in.get("/api/runs/20").get_json()
|
||||
assert active["suspect"] is False
|
||||
assert active["active"] is True
|
||||
|
||||
Reference in New Issue
Block a user